Skip to content

fixed examples for names of anonymous givens #13167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

SrTobi
Copy link
Contributor

@SrTobi SrTobi commented Jul 27, 2021

I think the rest of the name generation documentation is correct

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@bishabosha
Copy link
Member

@julienrf should this PR be reopened at https://github.com/scala/docs.scala-lang?

@julienrf
Copy link
Contributor

Good catch @bishabosha, yes it would be great to make these changes there, thanks! The sources are here https://github.com/scala/docs.scala-lang/tree/main/_scala3-reference/contextual

@bishabosha
Copy link
Member

@SrTobi would you like to close this and apply the same changes at https://github.com/scala/docs.scala-lang/pulls?

@bishabosha bishabosha assigned SrTobi and unassigned bishabosha Aug 17, 2021
@odersky
Copy link
Contributor

odersky commented Mar 13, 2022

What is the status here?

@bishabosha
Copy link
Member

What is the status here?

since we are making dotty docs the source of truth again, I will rebase this and merge

@bishabosha bishabosha force-pushed the tobias/given-name-docs branch from b94ee42 to 99dec18 Compare March 14, 2022 10:35
@bishabosha bishabosha merged commit aecdc79 into scala:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants